From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: next-20140313 - build error in e1000e driver
Date: Fri, 14 Mar 2014 10:33:55 +0200 [thread overview]
Message-ID: <20140314083354.GC5018@intel.com> (raw)
In-Reply-To: <59774.1394739168@turing-police.cc.vt.edu>
On Thu, Mar 13, 2014 at 03:32:48PM -0400, Valdis Kletnieks wrote:
> My kernel has CONFIG_PM_SLEEP=n, which leads to hilarity...
>
> CC drivers/net/ethernet/intel/e1000e/netdev.o
> drivers/net/ethernet/intel/e1000e/netdev.c:7079:13: error: 'e1000e_pm_suspend' undeclared here (not in a function)
> .suspend = e1000e_pm_suspend,
> ^
> drivers/net/ethernet/intel/e1000e/netdev.c:7080:13: error: 'e1000e_pm_resume' undeclared here (not in a function)
> .resume = e1000e_pm_resume,
> ^
> make[5]: *** [drivers/net/ethernet/intel/e1000e/netdev.o] Error 1
> make[4]: *** [drivers/net/ethernet/intel/e1000e] Error 2
> make[3]: *** [drivers/net/ethernet/intel] Error 2
> make[2]: *** [drivers/net/ethernet] Error 2
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2
>
> Commit 38a529b5d4 claims to fix a related issue, but doesn't seem to do
> so correctly.
It fixes it correctly. The problem is that it got broke again with
the following commit:
d392f8ddb8 e1000e: Refactor PM flows
prev parent reply other threads:[~2014-03-14 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 19:32 Valdis Kletnieks
2014-03-13 23:01 ` [E1000-devel] " Jeff Kirsher
2014-03-14 8:33 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314083354.GC5018@intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=e1000-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome