mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Don Zickus <dzickus@redhat.com>
Cc: acme@redhat.com, jmario@redhat.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] perf: Speed up thread map generation
Date: Fri, 14 Mar 2014 17:12:06 +0100	[thread overview]
Message-ID: <20140314161206.GC5276@krava.redhat.com> (raw)
In-Reply-To: <1394808224-113774-1-git-send-email-dzickus@redhat.com>

On Fri, Mar 14, 2014 at 10:43:44AM -0400, Don Zickus wrote:
> When trying to capture perf data on a system running spejbb2013,
> perf hung for about 15 minutes.  This is because it took that
> long to gather about 10,000 thread maps and process them.
> 
> I don't think a user wants to wait that long.
> 
> Instead, recognize that thread maps are roughly equivalent to
> pid maps and just quickly copy those instead.
> 
> To do this, I synthesize 'fork' events, this eventually calls
> thread__fork() and copies the maps over.
> 
> The overhead goes from 15 minutes down to about a few seconds.
> 
> Signed-off-by: Don Zickus <dzickus@redhat.com>
> --
> V2: based on Jiri's comments, moved malloc up a level
>     and made sure the memory was freed

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

  reply	other threads:[~2014-03-14 16:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14 14:43 Don Zickus
2014-03-14 16:12 ` Jiri Olsa [this message]
2014-03-17  1:45 ` Namhyung Kim
2014-03-18 13:43   ` Arnaldo Carvalho de Melo
2014-03-18 14:20     ` Namhyung Kim
2014-03-19 13:07   ` [tip:perf/core] perf tools: Fix memory leak when synthesizing thread records tip-bot for Namhyung Kim
2014-03-18  8:31 ` [tip:perf/core] perf tools: Speed up thread map generation tip-bot for Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140314161206.GC5276@krava.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@redhat.com \
    --cc=dzickus@redhat.com \
    --cc=jmario@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome