From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756187AbaCNXmr (ORCPT ); Fri, 14 Mar 2014 19:42:47 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:51000 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752030AbaCNXmp (ORCPT ); Fri, 14 Mar 2014 19:42:45 -0400 Date: Sat, 15 Mar 2014 00:42:33 +0100 From: Francois Romieu To: hayeswang Cc: "'David Miller'" , David.Laight@ACULAB.COM, netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH net-next v3 1/2] r8152:addRTL8152_EARLY_AGG_TIMEOUT_SUPER Message-ID: <20140314234233.GA2341@electric-eye.fr.zoreil.com> References: <063D6719AE5E284EB5DD2968C1650D6D0F6DCB6E@AcuExch.aculab.com> <20140313.132222.536931544768069240.davem@davemloft.net> <20140314.000741.1829674011496195593.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hayeswang : [...] > Besides, I don't wish to modify the setting by ethtool when re-loading > the driver or rebooting every time. Why ? The recipe is different but there isn't much setup difference between a module param and an ethtool command that is run through udev. The latter is more versatile though. > Excuse me. Why is it not accepted for being a Kconfig parameter. You have stated that the optimal value is not easy to figure. It's thus hard to give much credit to an hardcoded solution. -- Ueimor