From: David Miller <davem@davemloft.net>
To: haiyangz@microsoft.com
Cc: netdev@vger.kernel.org, kys@microsoft.com, olaf@aepfle.de,
jasowang@redhat.com, linux-kernel@vger.kernel.org,
driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH net-next,v2,1/1] hyperv: Add support for virtual Receive Side Scaling (vRSS)
Date: Mon, 17 Mar 2014 16:19:55 -0400 (EDT) [thread overview]
Message-ID: <20140317.161955.776021754942208577.davem@davemloft.net> (raw)
In-Reply-To: <1394903887-30421-2-git-send-email-haiyangz@microsoft.com>
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Sat, 15 Mar 2014 10:18:07 -0700
> - if (netif_queue_stopped(ndev) && !net_device->start_remove &&
> - (hv_ringbuf_avail_percent(&device->channel->outbound)
> - > RING_AVAIL_PERCENT_HIWATER ||
> - num_outstanding_sends < 1))
> - netif_wake_queue(ndev);
> + if (netif_tx_queue_stopped(netdev_get_tx_queue(ndev, q_idx))
> + && !net_device->start_remove &&
> + (hv_ringbuf_avail_percent(&channel->outbound)
> + > RING_AVAIL_PERCENT_HIWATER || queue_sends < 1))
> + netif_tx_wake_queue(netdev_get_tx_queue(
> + ndev, q_idx));
This is not indented properly, make it:
if (A && B &&
(C >
D || E < 1))
Never put operators at the beginning of a conditional line, always at
the end.
next prev parent reply other threads:[~2014-03-17 20:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 17:18 [PATCH net-next,v2,0/1] " Haiyang Zhang
2014-03-15 17:18 ` [PATCH net-next,v2,1/1] " Haiyang Zhang
2014-03-17 20:19 ` David Miller [this message]
2014-03-17 20:54 ` Haiyang Zhang
2014-03-17 20:27 ` Ben Hutchings
2014-03-17 20:59 ` Haiyang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317.161955.776021754942208577.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®