mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: kbuild-all@01.org, kbuild test robot <fengguang.wu@intel.com>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: [PATCH] xen: declare notifier_block on xen-ops.h
Date: Mon, 17 Mar 2014 08:48:51 +0100	[thread overview]
Message-ID: <20140317074850.GB1767@redhat.com> (raw)
In-Reply-To: <5323aab1.r24xwrkmR/N+a3KK%fengguang.wu@intel.com>

Patch fixes below warnings:

   In file included from arch/x86/xen/xen-ops.h:7:0,
                    from arch/x86/xen/vga.c:9:
>> include/xen/xen-ops.h:19:42: warning: 'struct notifier_block' declared inside parameter list [enabled by default]
    void xen_resume_notifier_register(struct notifier_block *nb);
                                             ^
>> include/xen/xen-ops.h:19:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>> include/xen/xen-ops.h:20:44: warning: 'struct notifier_block' declared inside parameter list [enabled by default]
    void xen_resume_notifier_unregister(struct notifier_block *nb);

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
 drivers/xen/manage.c  | 1 -
 include/xen/xen-ops.h | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
index 96e4173..fc6c94c 100644
--- a/drivers/xen/manage.c
+++ b/drivers/xen/manage.c
@@ -13,7 +13,6 @@
 #include <linux/freezer.h>
 #include <linux/syscore_ops.h>
 #include <linux/export.h>
-#include <linux/notifier.h>
 
 #include <xen/xen.h>
 #include <xen/xenbus.h>
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index cc8b4cb..acc7b7a 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -2,6 +2,7 @@
 #define INCLUDE_XEN_OPS_H
 
 #include <linux/percpu.h>
+#include <linux/notifier.h>
 #include <asm/xen/interface.h>
 
 DECLARE_PER_CPU(struct vcpu_info *, xen_vcpu);
-- 
1.7.11.7


       reply	other threads:[~2014-03-17  7:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5323aab1.r24xwrkmR/N+a3KK%fengguang.wu@intel.com>
2014-03-17  7:48 ` Stanislaw Gruszka [this message]
2014-03-17 17:56   ` [Xen-devel] " David Vrabel
2014-03-18  6:52     ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140317074850.GB1767@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome