From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932847AbaCQLan (ORCPT ); Mon, 17 Mar 2014 07:30:43 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:38667 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932754AbaCQLal (ORCPT ); Mon, 17 Mar 2014 07:30:41 -0400 Date: Mon, 17 Mar 2014 11:30:39 +0000 From: Mark Rutland To: Boris BREZILLON Cc: boris brezillon , Bo Shen , Mark Brown , "nicolas.ferre@atmel.com" , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Rob Landley , Mark Brown , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver Message-ID: <20140317113039.GG8070@e106331-lin.cambridge.arm.com> References: <1395049541-28128-1-git-send-email-voice.shen@atmel.com> <1395049541-28128-8-git-send-email-voice.shen@atmel.com> <20140317100219.GB8070@e106331-lin.cambridge.arm.com> <5326CBE0.1000309@overkiz.com> <20140317104804.GE8070@e106331-lin.cambridge.arm.com> <5326DB79.50501@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5326DB79.50501@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 17, 2014 at 11:24:41AM +0000, Boris BREZILLON wrote: > Le 17/03/2014 11:48, Mark Rutland a écrit : > > On Mon, Mar 17, 2014 at 10:18:08AM +0000, boris brezillon wrote: > >> Hello Mark, > >> > >> Le 17/03/2014 11:02, Mark Rutland a écrit : > >>> On Mon, Mar 17, 2014 at 09:45:40AM +0000, Bo Shen wrote: > >>>> From: Boris BREZILLON > >>>> > >>>> Signed-off-by: Boris BREZILLON > >>>> Signed-off-by: Bo Shen > >>>> --- > >>>> > >>>> Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++ > >>>> 1 file changed, 2 insertions(+) > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt > >>>> index 8bbe50c..aca341c 100644 > >>>> --- a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt > >>>> +++ b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt > >>>> @@ -3,6 +3,8 @@ Atmel ASoC driver with wm8904 audio codec complex > >>>> Required properties: > >>>> - compatible: "atmel,asoc-wm8904" > >>>> - atmel,model: The user-visible name of this sound complex. > >>>> + - clocks: A list of clocks needed by the wm8904 chip. > >>>> + - clock-output-names: Driver related clock names. Shall contain "pck0". > >>> The word "driver" doesn't need to appear in biding documents, and this > >>> fails to describe what it sets out to. How about the following: > >>> > >>> - clocks: a list of phandle + clock-specifier pairs, one for each entry > >>> in clock-names. > >> Agreed. > >>> - clock-names: Should contain "pck0" > >> After thinking a bit more about it, this can be any programmable clk (pckX). > > Huh? > > > > The clock-names property describes the names of the inputs to the > > device, from the view of the device, not the names of the clocks fed > > into those inputs. > > > > What are the names of the clock input lines on the wm8904? > > mclk, and you're right, this is how we should name the clk (I just got > influenced by the existing driver, which was requesting pck0). > > This gives the following: > > - clock-names: Should contain "mclk" > > Do you agree ? That sounds right to me. Cheers, Mark.