Re: [PATCH] SPI: Add driver for Cadence SPI controller

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

On Mon, Mar 17, 2014 at 12:59:11PM -0500, Josh Cartwright wrote:
> On Mon, Mar 17, 2014 at 05:30:17PM +0000, Mark Brown wrote:
> > On Mon, Mar 17, 2014 at 05:35:36PM +0530, Harini Katakam wrote:

> > > +static int __maybe_unused cdns_spi_suspend(struct device *dev)
> > > +{

> > This needs to call spi_master_suspend() as well (and similarly on
> > resume).

> I'm not that familiar with the SPI core, but this seems like an
> inversion.  Is there a reason why the SPI master class doesn't implement
> suspend/resume() callbacks which handle stopping/starting the queue
> automatically for all masters?

This is for users of an optional feature of the infrastructure.  We
probably should just call it anyway since it does have checks for the
feature being used (but given all the open coding around this stuff I'd
need to verify that the class callbacks would reliably get called).

In any case that's not happening now and the driver as it stands is
buggy since it's trampling all over the hardware without syncing with
anything that isn't ongoing.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]