From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Liu Hua <sdu.liu@huawei.com>
Cc: wangnan0@huawei.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, peifeiyue@huawei.com
Subject: Re: [PATCH] ARM: kdump: Avoid overflow when converting pfn to physaddr
Date: Tue, 18 Mar 2014 10:48:55 +0000 [thread overview]
Message-ID: <20140318104855.GU21483@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1395138042-62364-1-git-send-email-sdu.liu@huawei.com>
On Tue, Mar 18, 2014 at 06:20:42PM +0800, Liu Hua wrote:
> When we configure CONFIG_LPAE=y, pfn << PAGE_SHIFT will
> overflow if pfn >= 0x100000 in copy_oldmem_page.
>
> So use __pfn_to_phys for converting.
Yes. The sad thing is that if you grep the kernel for similar things,
it's littered with this problem. I'm not sure whether anyone
particularly "owns" the crash_dump.c file - Mika Westerberg and
Olaf Hering were the last two to touch it... I guess put this in my
patch system please.
Thanks.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-03-18 10:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 10:20 Liu Hua
2014-03-18 10:48 ` Russell King - ARM Linux [this message]
2014-03-22 5:14 ` Liu hua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318104855.GU21483@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peifeiyue@huawei.com \
--cc=sdu.liu@huawei.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®