From: Mark Brown <broonie@kernel.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com
Subject: Re: [PATCH 2/4] regulator: max8660: Silence checkpatch warnings
Date: Tue, 18 Mar 2014 12:39:59 +0000 [thread overview]
Message-ID: <20140318123959.GT11706@sirena.org.uk> (raw)
In-Reply-To: <1395138184-25287-2-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
On Tue, Mar 18, 2014 at 03:53:02PM +0530, Sachin Kamat wrote:
> Silences the following type of error/warnings:
> ERROR: that open brace { should be on the previous line
> WARNING: Missing a blank line after declarations
Applied, but...
> - static const u8 max8660_addresses[MAX8660_N_REGS] =
> - { 0x10, 0x12, 0x20, 0x23, 0x24, 0x29, 0x2a, 0x32, 0x33, 0x39, 0x80 };
> + static const u8 max8660_addresses[MAX8660_N_REGS] = {
> + 0x10, 0x12, 0x20, 0x23, 0x24, 0x29, 0x2a, 0x32, 0x33, 0x39, 0x80 };
Think about what you're doing here - you want the }; on a new line too.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-18 12:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 10:23 [PATCH 1/4] regulator: dbx500-prcmu: " Sachin Kamat
2014-03-18 10:23 ` [PATCH 2/4] regulator: max8660: " Sachin Kamat
2014-03-18 12:39 ` Mark Brown [this message]
2014-03-19 8:14 ` Sachin Kamat
2014-03-18 10:23 ` [PATCH 3/4] regulator: max8925: Silence checkpatch warning Sachin Kamat
2014-03-18 12:40 ` Mark Brown
2014-03-18 10:23 ` [PATCH 4/4] regulator: max8952: " Sachin Kamat
2014-03-18 12:43 ` Mark Brown
2014-03-18 12:38 ` [PATCH 1/4] regulator: dbx500-prcmu: Silence checkpatch warnings Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318123959.GT11706@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®