From: Peter Zijlstra <peterz@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
Jerome Marchand <jmarchan@redhat.com>,
linux-kernel@vger.kernel.org,
David Vrabel <david.vrabel@citrix.com>,
Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
Subject: Re: zram: zsmalloc calls sleeping function from atomic context
Date: Tue, 18 Mar 2014 13:52:45 +0100 [thread overview]
Message-ID: <20140318125245.GG22095@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <20140317160117.9bfbfdd5128d45a80f58070c@linux-foundation.org>
On Mon, Mar 17, 2014 at 04:01:17PM -0700, Andrew Morton wrote:
> btw, I note that vunmap() itself already has a might_sleep() in it, and
> I can't work out why - I don't think it _does_ sleep. The changelog to
> 34754b69a6f87aa6aa is, in toto:
>
> "x86: make vmap yell louder when it is used under irqs_disabled()"
>
> No explanation *why*. And why didn't it use WARN_ON(irqs_disabled())?
Man I suck.. and 5 years ago too. I can barely remember last week.
Lets see if the email archive has clues.
vmap()
get_vm_area_caller()
__get_vm_area_node(.gfp = GFP_KERNEL)
kmalloc_node(gfp);
It does sleep.
https://lkml.org/lkml/2009/2/13/115
prev parent reply other threads:[~2014-03-18 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 14:43 Sergey Senozhatsky
2014-03-17 23:01 ` Andrew Morton
2014-03-18 12:05 ` David Vrabel
2014-03-18 12:52 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318125245.GG22095@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david.vrabel@citrix.com \
--cc=dietmar.hahn@ts.fujitsu.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®