From: Andrew Morton <akpm@linux-foundation.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] MINIX: specific inode data access standardization
Date: Tue, 18 Mar 2014 14:25:31 -0700 [thread overview]
Message-ID: <20140318142531.ebb7f50ed458df868d64cf10@linux-foundation.org> (raw)
In-Reply-To: <20140318185221.697f8368fca2e51728e201ca@skynet.be>
On Tue, 18 Mar 2014 18:52:21 +0100 Fabian Frederick <fabf@skynet.be> wrote:
> minix_i uppercase conversion (like majority of other filesystems).
>
> ...
>
> @@ -255,7 +255,7 @@ struct inode *minix_new_inode(const struct inode *dir, umode_t mode, int *error)
> inode->i_ino = j;
> inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC;
> inode->i_blocks = 0;
> - memset(&minix_i(inode)->u, 0, sizeof(minix_i(inode)->u));
> + memset(&MINIX_I(inode)->u, 0, sizeof(MINIX_I(inode)->u));
> insert_inode_hash(inode);
> mark_inode_dirty(inode);
minix is correct and the other filesystems are wrong.
minix_i() is a regular C function. There is no earthly reason why it
should be all-caps.
prev parent reply other threads:[~2014-03-18 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 17:52 Fabian Frederick
2014-03-18 21:25 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140318142531.ebb7f50ed458df868d64cf10@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome