mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Levente Kurusa <levex@linux.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] regmap: Ensure regmap_register_patch() is compatible with fast_io
Date: Tue, 18 Mar 2014 16:07:10 +0000	[thread overview]
Message-ID: <20140318160710.GE11706@sirena.org.uk> (raw)
In-Reply-To: <CAAsK9AG7-12Y7RRdmmHDdGYqNh+qBuciD5YaptXZ_+rkvEGNjg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

On Tue, Mar 18, 2014 at 02:43:18PM +0100, Levente Kurusa wrote:
> 2014-03-18 13:02 GMT+01:00 Mark Brown <broonie@kernel.org>:

> > +       if (p) {
> > +               memcpy(p + map->patch_regs, regs, num_regs * sizeof(*regs));
> > +               map->patch = p;
> > +               map->patch_regs += num_regs;
> > +       } else {
> > +               return -ENOMEM;
> > +       }
> > +

> I think that is not checkpatch-safe :-)

What makes you say that?  If you think there's some problem say what it
is please...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2014-03-18 16:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 12:02 Mark Brown
2014-03-18 13:43 ` Levente Kurusa
2014-03-18 16:07   ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140318160710.GE11706@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=levex@linux.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®