mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Frank Ch. Eigler" <fche@redhat.com>,
	Johannes Berg <johannes.berg@intel.com>
Subject: Re: [RFC PATCH v5 1/3] Tracepoint cleanup: remove unused API functions
Date: Wed, 19 Mar 2014 10:33:55 -0400	[thread overview]
Message-ID: <20140319103355.5fb39ef6@gandalf.local.home> (raw)
In-Reply-To: <1395151546-20445-2-git-send-email-mathieu.desnoyers@efficios.com>

On Tue, 18 Mar 2014 10:05:44 -0400
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:

> After the following commit:
> 
> commit b75ef8b44b1cb95f5a26484b0e2fe37a63b12b44
> Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Date:   Wed Aug 10 15:18:39 2011 -0400
> 
>     Tracepoint: Dissociate from module mutex
> 
> The following functions became unnecessary:
> 
> - tracepoint_probe_register_noupdate,
> - tracepoint_probe_unregister_noupdate,
> - tracepoint_probe_update_all.
> 
> In fact, none of the in-kernel tracers, nor LTTng, nor SystemTAP use
> them. Remove those.
> 
> Moreover, the functions:
> 
> - tracepoint_iter_start,
> - tracepoint_iter_next,
> - tracepoint_iter_stop,
> - tracepoint_iter_reset.
> 
> are unused by in-kernel tracers, LTTng and SystemTAP. Remove those too.
> 

New warning caused by this patch:

tracepoint.c:446:13: warning: 'tracepoint_add_old_probes' defined but not used [-Wunused-function]
    struct tp_probes, probes[0]);

--  Steve

  reply	other threads:[~2014-03-19 14:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 14:05 [RFC PATCH v5 0/3] Tracepoint API simplification/cleanup Mathieu Desnoyers
2014-03-18 14:05 ` [RFC PATCH v5 1/3] Tracepoint cleanup: remove unused API functions Mathieu Desnoyers
2014-03-19 14:33   ` Steven Rostedt [this message]
2014-03-18 14:05 ` [RFC PATCH v5 2/3] Tracepoint API doc update: data argument Mathieu Desnoyers
2014-03-18 14:05 ` [RFC PATCH v5 3/3] Tracepoint: register/unregister struct tracepoint Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140319103355.5fb39ef6@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=fche@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=johannes.berg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®