From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934179AbaCSOGG (ORCPT ); Wed, 19 Mar 2014 10:06:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22133 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933380AbaCSOGE (ORCPT ); Wed, 19 Mar 2014 10:06:04 -0400 Date: Wed, 19 Mar 2014 15:05:57 +0100 From: Jiri Olsa To: Don Zickus Cc: acme@ghostprotocols.net, LKML , jmario@redhat.com, fowles@inreach.com, eranian@google.com Subject: Re: [PATCH 15/19] perf, c2c: Add callchain support Message-ID: <20140319140557.GH1449@krava.brq.redhat.com> References: <1393609388-40489-1-git-send-email-dzickus@redhat.com> <1393609388-40489-16-git-send-email-dzickus@redhat.com> <20140319130035.GC7423@krava.brq.redhat.com> <20140319135328.GB25953@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140319135328.GB25953@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 19, 2014 at 09:53:28AM -0400, Don Zickus wrote: > On Wed, Mar 19, 2014 at 02:00:35PM +0100, Jiri Olsa wrote: > > On Fri, Feb 28, 2014 at 12:43:04PM -0500, Don Zickus wrote: > > > > SNIP > > > > > > > > +static int > > > +opt_callchain_cb(const struct option *opt, const char *arg, int unset) > > > +{ > > > + struct perf_c2c *c2c = (struct perf_c2c *)opt->value; > > > + char *tok, *tok2; > > > + char *endptr; > > > > > > this still needs to be shared with report code, but > > I'm guessing V2 was about moving to hist_entry-ies > > I guess I don't understand this? I don't use the report code. Is there > another way I can get this? opt_callchain_cb is same as parse_callchain_opt function, the argument parsing code could be shared jirka