From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: David Miller <davem@davemloft.net>,
haiyangz@microsoft.com, netdev@vger.kernel.org,
kys@microsoft.com, olaf@aepfle.de, jasowang@redhat.com,
linux-kernel@vger.kernel.org,
driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH net-next,v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)
Date: Thu, 20 Mar 2014 08:00:10 +1100 [thread overview]
Message-ID: <20140320080010.77e27d5d7086a57d39f79e6d@canb.auug.org.au> (raw)
In-Reply-To: <532A1275.2020208@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 542 bytes --]
On Thu, 20 Mar 2014 00:56:05 +0300 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
>
> On 03/19/2014 11:40 PM, David Miller wrote:
>
> >> +extern u8 netvsc_hash_key[];
>
> > We no longer use extern in header file function declarations.
>
> Wait, this is a variable declaration. :-)
And the need for the extern on variable declarations was one reason I
gave for not removing it from the function declarations (consistency is
good :-)).
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-19 21:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 22:15 Haiyang Zhang
2014-03-19 20:40 ` David Miller
2014-03-19 21:36 ` Haiyang Zhang
2014-03-19 21:56 ` Sergei Shtylyov
2014-03-19 21:00 ` Stephen Rothwell [this message]
2014-03-20 3:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320080010.77e27d5d7086a57d39f79e6d@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=davem@davemloft.net \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®