From: Aaron Tomlin <atomlin@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
Andrew Shewmaker <agshew@gmail.com>,
Li Zefan <lizefan@huawei.com>, Dario Faggioli <raistlin@linux.it>,
Dave Hansen <dave.hansen@linux.intel.com>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Eric Dumazet <edumazet@google.com>,
Willem de Bruijn <willemb@google.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Pavel Emelyanov <xemul@parallels.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] sysctl: fix incorrect write position handling
Date: Thu, 20 Mar 2014 10:09:54 +0000 [thread overview]
Message-ID: <20140320100954.GD4701@atomlin.usersys.redhat.com> (raw)
In-Reply-To: <20140320015634.GH3132@tassilo.jf.intel.com>
On Wed, Mar 19, 2014 at 06:56:34PM -0700, Andi Kleen wrote:
> >
> > Why are we fixing this?
>
> Also sysctl writes are root only anyways.
>
> Protecting root against root? Seems odd.
>
> -Andi
I agree. I don't see the point here.
Regards,
--
Aaron Tomlin
next prev parent reply other threads:[~2014-03-20 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 17:17 [PATCH 0/2] " Kees Cook
2014-03-18 17:17 ` [PATCH 1/2] " Kees Cook
2014-03-19 22:25 ` Andrew Morton
2014-03-19 23:35 ` Kees Cook
2014-03-20 1:56 ` Andi Kleen
2014-03-20 10:09 ` Aaron Tomlin [this message]
2014-03-20 20:24 ` Kees Cook
2014-03-18 17:18 ` [PATCH 2/2] test: make sure sysctl writing works as expected Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320100954.GD4701@atomlin.usersys.redhat.com \
--to=atomlin@redhat.com \
--cc=agshew@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=lizefan@huawei.com \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=raistlin@linux.it \
--cc=riel@redhat.com \
--cc=willemb@google.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome