From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932796AbaCTLl1 (ORCPT ); Thu, 20 Mar 2014 07:41:27 -0400 Received: from mail.karo-electronics.de ([81.173.242.67]:51970 "EHLO mail.karo-electronics.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbaCTLlZ convert rfc822-to-8bit (ORCPT ); Thu, 20 Mar 2014 07:41:25 -0400 Date: Thu, 20 Mar 2014 12:40:55 +0100 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Mark Rutland Cc: Dmitry Torokhov , Fugang Duan , "grant.likely@linaro.org" , Henrik Rydberg , Ian Campbell , Jingoo Han , Kumar Gala , Pawel Moll , Rob Herring , Rob Landley , Sachin Kamat , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Simon Budig Subject: Re: [PATCHv4 2/5] Input: edt-ft5x06: Add DT support Message-ID: <20140320124055.53d469e7@ipc1.ka-ro> In-Reply-To: <20140320093719.GB14420@e106331-lin.cambridge.arm.com> References: <1395234563-11034-1-git-send-email-LW@KARO-electronics.de> <1395234563-11034-3-git-send-email-LW@KARO-electronics.de> <20140320093719.GB14420@e106331-lin.cambridge.arm.com> Organization: Ka-Ro electronics GmbH X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Mark Rutland wrote: > On Wed, Mar 19, 2014 at 01:09:20PM +0000, Lothar Waßmann wrote: > > > > Signed-off-by: Lothar Waßmann > > --- > > .../bindings/input/touchscreen/edt-ft5x06.txt | 41 ++++++ > > drivers/input/touchscreen/edt-ft5x06.c | 144 +++++++++++++++----- > > 2 files changed, 154 insertions(+), 31 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt > > new file mode 100644 > > index 0000000..e5adc76 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt > > @@ -0,0 +1,41 @@ > > +FocalTech EDT-FT5x06 Polytouch driver > > +===================================== > > + > > +Required properties: > > + - compatible: "edt,edt-ft5x06" > > Is the 'x' part of a particular product name, or is this a class of > devices? > The FT5x06 datasheet lists 3 variants for different panel sizes. I'll add distinct compatible strings for those chips, though their SW interface is (currently) identical: |Required properties: | - compatible: "edt,edt-ft5206", "edt,edt-ft5x06" | or: "edt,edt-ft5306", "edt,edt-ft5x06" | or: "edt,edt-ft5406", "edt,edt-ft5x06" > > + - reg: I2C slave address of the chip (0x38) > > + - interrupt-parent: a phandle pointing to the interrupt controller > > + serving the interrupt for this chip > > + - interrupts: interrupt specification for this chip > > How many? What are they for? > I'll change it to: | - interrupts: interrupt specification for the touchdetect | interrupt > > + - report_rate: allows setting the report rate in the range from 3 to > > + 14. > > However, why can the kernel not decide the report rate? This doesn't > sound like something that needs to vary per-board. > > Also, s/_/-/ in property names, please. > OK, I'll drop the property, which also simplyfies the code a bit. > > +#define EDT_GET_PROP(name, reg) { \ > > + const u32 *prop = of_get_property(np, #name, NULL); \ > > + if (prop) \ > > + edt_ft5x06_register_write(tsdata, reg, be32_to_cpu(*prop)); \ > > +} > > Use of_property_read_u32, it'll handle endianness conversion for you. > > Use of of_get_property is almost always wrong. > Sure. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________