From: Greg KH <gregkh@linuxfoundation.org>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: nandu.hgowda@gmail.com, devel@driverdev.osuosl.org,
shaun@xresource.ca, gulsah.1004@gmail.com,
sachin.kamat@linaro.org, peter.p.waskiewicz.jr@intel.com,
ebru.akagunduz@gmail.com, dulshani.gunawardhana89@gmail.com,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
himangi774@gmail.com, viro@zeniv.linux.org.uk, joe@perches.com,
fempsci@gmail.com, speiro@ai2.upv.es
Subject: Re: [PATCH v2] staging: cxt1e1: replace OS_kmalloc/OS_kfree with kmalloc/kfree
Date: Thu, 20 Mar 2014 21:27:37 -0700 [thread overview]
Message-ID: <20140321042737.GA4439@kroah.com> (raw)
In-Reply-To: <1983239.9vdN5jE4dT@daeseok-laptop.cloud.net>
On Fri, Mar 21, 2014 at 01:15:23PM +0900, Daeseok Youn wrote:
>
> Replace OS_kmalloc/OS_kfree with kmalloc/kfree.
You should replace it with kzalloc, not kmalloc, as OS_kmalloc() zeroed
out the allocated data:
> -static inline void *
> -OS_kmalloc (size_t size)
> -{
> - char *ptr = kmalloc (size, GFP_KERNEL | GFP_DMA);
> -
> - if (ptr)
> - memset (ptr, 0, size);
> - return ptr;
> -}
greg k-h
next prev parent reply other threads:[~2014-03-21 4:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 4:15 Daeseok Youn
2014-03-21 4:27 ` Greg KH [this message]
2014-03-21 4:36 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321042737.GA4439@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dhowells@redhat.com \
--cc=dulshani.gunawardhana89@gmail.com \
--cc=ebru.akagunduz@gmail.com \
--cc=fempsci@gmail.com \
--cc=gulsah.1004@gmail.com \
--cc=himangi774@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nandu.hgowda@gmail.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=sachin.kamat@linaro.org \
--cc=shaun@xresource.ca \
--cc=speiro@ai2.upv.es \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®