From: Ingo Molnar <mingo@kernel.org>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [patch] x86/UV: Set n_lshift based on GAM_GR_CONFIG MMR for UV3
Date: Fri, 21 Mar 2014 08:54:16 +0100 [thread overview]
Message-ID: <20140321075416.GA23556@gmail.com> (raw)
In-Reply-To: <20140320191354.GA30582@sgi.com>
* Dimitri Sivanich <sivanich@sgi.com> wrote:
> Set the UV n_lshift value based on the GAM_GR_CONFIG MMR for UV3, making it
> independent of the socket m_val.
>
> Remove unneeded macros.
>
> Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
> ---
> arch/x86/include/asm/uv/uv_hub.h | 12 ---------
> arch/x86/include/asm/uv/uv_mmrs.h | 42 ++++++++++++++++++++++++++++++++-
> arch/x86/kernel/apic/x2apic_uv_x.c | 15 +++++++++--
> 3 files changed, 54 insertions(+), 15 deletions(-)
Please use the customary changelog style we use in the kernel:
" Current code does (A), this has a problem when (B).
We can improve this doing (C), because (D)."
(Of if it's a cleanup only with no functional effects then please
state it so in the title and changelog.)
Thanks,
Ingo
next prev parent reply other threads:[~2014-03-21 7:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 19:13 Dimitri Sivanich
2014-03-21 7:54 ` Ingo Molnar [this message]
2014-03-21 14:16 ` [PATCH] " Dimitri Sivanich
2014-03-31 7:30 ` Ingo Molnar
2014-03-31 14:37 ` Dimitri Sivanich
2014-04-01 11:07 ` [tip:x86/uv] " tip-bot for Dimitri Sivanich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321075416.GA23556@gmail.com \
--to=mingo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sivanich@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome