From: Steven Rostedt <rostedt@goodmis.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH 2/2] tools lib traceevent: Do not call warning() directly
Date: Fri, 21 Mar 2014 11:24:07 -0400 [thread overview]
Message-ID: <20140321112407.3943d034@gandalf.local.home> (raw)
In-Reply-To: <1395192174-26273-2-git-send-email-namhyung@kernel.org>
On Wed, 19 Mar 2014 10:22:54 +0900
Namhyung Kim <namhyung@kernel.org> wrote:
> The patch 3a3ffa2e82205 ("tools lib traceevent: Report better error
> message on bad function args") added the error message but it seems
> there's no reason to call warning() directly.
>
> So change it to do_warning_event() to provide event information too.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
next prev parent reply other threads:[~2014-03-21 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1395192174-26273-1-git-send-email-namhyung@kernel.org>
2014-03-21 15:22 ` [PATCH 1/2] tools lib traceevent: Print event name when show warning if possible Steven Rostedt
[not found] ` <1395192174-26273-2-git-send-email-namhyung@kernel.org>
2014-03-21 15:24 ` Steven Rostedt [this message]
2014-04-14 14:52 ` [tip:perf/urgent] tools lib traceevent: Do not call warning() directly tip-bot for Namhyung Kim
2014-04-14 14:51 ` [tip:perf/urgent] tools lib traceevent: Print event name when show warning if possible tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321112407.3943d034@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®