From: Mark Brown <broonie@kernel.org>
To: Jonghwan Choi <jhbird.choi@samsung.com>
Cc: "'open list'" <linux-kernel@vger.kernel.org>,
"'Liam Girdwood'" <lgirdwood@gmail.com>
Subject: Re: [PATCH] regulator: core: Reduce busy-wait looping
Date: Fri, 21 Mar 2014 11:50:40 +0000 [thread overview]
Message-ID: <20140321115040.GL11706@sirena.org.uk> (raw)
In-Reply-To: <000001cf44ad$a8e2f1b0$faa8d510$%choi@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
On Fri, Mar 21, 2014 at 11:31:25AM +0900, Jonghwan Choi wrote:
> Commit 5df529d440("regulator: core: Reduce busy-wait looping")
> can also be used in regulator_do_set_voltage.
This is good as a change but please factor it out into a function so we
don't have the same problem again with future changes (I'm surprised
there isn't one in the generic code somewhere but if not we can do that
as a second stage, regulator only is fine for now) and make sure that
the lines are less than 80 columns.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-21 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 2:31 Jonghwan Choi
2014-03-21 11:50 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-09-20 11:51 Thierry Reding
2013-09-20 16:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321115040.GL11706@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jhbird.choi@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®