From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752168AbaCUWI2 (ORCPT ); Fri, 21 Mar 2014 18:08:28 -0400 Received: from top.free-electrons.com ([176.31.233.9]:59203 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751152AbaCUWIZ (ORCPT ); Fri, 21 Mar 2014 18:08:25 -0400 Date: Fri, 21 Mar 2014 23:08:22 +0100 From: Alexandre Belloni To: Sebastian Hesselbarth Cc: Mike Turquette , Jimmy Xu , Jisheng Zhang , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Antoine =?iso-8859-1?Q?T=E9nart?= Subject: Re: [PATCH v2 4/5] ARM: berlin/dt: add cpupll and syspll support to BG2CD Message-ID: <20140321220821.GI6443@piout.net> References: <1395432521-11055-1-git-send-email-alexandre.belloni@free-electrons.com> <1395432521-11055-5-git-send-email-alexandre.belloni@free-electrons.com> <532CB09E.5000408@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <532CB09E.5000408@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/03/2014 at 22:35:26 +0100, Sebastian Hesselbarth wrote : > On 03/21/2014 09:08 PM, Alexandre Belloni wrote: > >The Berlin BG2CD has two supported PLLs: CPU PLL and System PLL, add those to > >the SoC device tree. > > > >This also moves the remaining clocks from the clocks container node to the root. > > > >Signed-off-by: Alexandre Belloni > >--- > > arch/arm/boot/dts/berlin2cd.dtsi | 48 ++++++++++++++++++++++++++-------------- > > 1 file changed, 31 insertions(+), 17 deletions(-) > > > >diff --git a/arch/arm/boot/dts/berlin2cd.dtsi b/arch/arm/boot/dts/berlin2cd.dtsi > >index 094968c27533..bd4e9dd4867e 100644 > >--- a/arch/arm/boot/dts/berlin2cd.dtsi > >+++ b/arch/arm/boot/dts/berlin2cd.dtsi > >@@ -30,24 +30,24 @@ > [...] > >@@ -76,7 +76,21 @@ > > compatible = "arm,cortex-a9-twd-timer"; > > reg = <0xad0600 0x20>; > > interrupts = ; > >- clocks = <&sysclk>; > >+ clocks = <&twdclk>; > >+ }; > >+ > >+ syspll: syspll@ea0014 { > >+ compatible = "marvell,berlin2-pll"; > >+ clocks = <&smclk>; > >+ #clock-cells = <0>; > >+ reg = <0xf7ea0014 8>; > > nit: I prefer hex numbers all over for reg properties. berlin2q already > has them, and I'll fixup this and the one below myself. > Indeed, I did fix that for bg2q and documentation and forgot bg2 and bg2cd. > >+ }; > >+ > >+ cpupll: cpupll@ea003c { > >+ compatible = "marvell,berlin2-pll"; > >+ clocks = <&smclk>; > >+ #clock-cells = <0>; > >+ reg = <0xf7ea003c 8>; > > ditto. > > Sebastian > > > }; > > > > apb@e80000 { > > > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com