From: Al Viro <viro@ZenIV.linux.org.uk>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, lkp@01.org
Subject: Re: [rcuwalk] e2a728c2785: -29.4% aim7.2000.jobs-per-min, +71% turbostat.Pkg_W
Date: Sat, 22 Mar 2014 13:54:12 +0000 [thread overview]
Message-ID: <20140322135412.GF18016@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20140322115636.GA14400@localhost>
On Sat, Mar 22, 2014 at 07:56:36PM +0800, Fengguang Wu wrote:
> Hi Al,
>
> We noticed the below changes on
>
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git untested-mnt_hash
> commit e2a728c2785d6aab45d1a6d2c61e986d385c30bf ("rcuwalk: recheck mount_lock after mountpoint crossing attempts")
*doh*
Sorry about that - what happens is that __follow_mount_rcu() does that
check every time it's called, not on every negative lookup from
__lookup_mnt(). IOW, it's a massive overkill - most of the time
we don't call __lookup_mnt() at all, due to d_mountpoint() being false,
or get a positive from it.
Fixed and force-pushed; should get much better now...
prev parent reply other threads:[~2014-03-22 13:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-22 11:56 Fengguang Wu
2014-03-22 13:54 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140322135412.GF18016@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome