mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
	Andrew Morton <akpm@linux-foundation.org>,
	Josh Triplett <josh@freedesktop.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [patch 06/16] rcu: torture: Add missing destroy_timer_on_stack()
Date: Sun, 23 Mar 2014 15:09:27 -0000	[thread overview]
Message-ID: <20140323150753.205530990@linutronix.de> (raw)
In-Reply-To: <20140323150557.288925975@linutronix.de>

[-- Attachment #1: rcu-torture-add-missing-destroy_timer_on_stack.patch --]
[-- Type: text/plain, Size: 925 bytes --]

Otherwise we leak a tracking object if DEBUG_OBJECTS is enabled.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Josh Triplett <josh@freedesktop.org>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
---
 kernel/rcu/torture.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Index: tip/kernel/rcu/torture.c
===================================================================
--- tip.orig/kernel/rcu/torture.c
+++ tip/kernel/rcu/torture.c
@@ -1038,8 +1038,10 @@ rcu_torture_reader(void *arg)
 	} while (!kthread_should_stop() && fullstop == FULLSTOP_DONTSTOP);
 	VERBOSE_PRINTK_STRING("rcu_torture_reader task stopping");
 	rcutorture_shutdown_absorb("rcu_torture_reader");
-	if (irqreader && cur_ops->irq_capable)
+	if (irqreader && cur_ops->irq_capable) {
 		del_timer_sync(&t);
+		destroy_timer_on_stack(&t);
+	}
 	while (!kthread_should_stop())
 		schedule_timeout_uninterruptible(1);
 	return 0;



  parent reply	other threads:[~2014-03-23 15:13 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-23 15:09 [patch 00/16] timers: Plug debugobject leaks and use del_timer_sync() in exit/teardown Thomas Gleixner
2014-03-23 15:09 ` [patch 01/16] s390: tape: Use del_timer_sync() Thomas Gleixner
2014-03-24  6:22   ` Heiko Carstens
2014-03-23 15:09 ` [patch 02/16] s390: tape: Add missing destroy_timer_on_stack() Thomas Gleixner
2014-03-24  6:22   ` Heiko Carstens
2014-03-23 15:09 ` [patch 03/16] s390: net: lcs: " Thomas Gleixner
2014-03-24  6:22   ` Heiko Carstens
2014-03-23 15:09 ` [patch 04/16] scsi: qla1280: " Thomas Gleixner
2014-03-23 15:09 ` Thomas Gleixner [this message]
2014-03-23 16:01   ` [patch 06/16] rcu: torture: " Paul E. McKenney
2014-03-23 18:13   ` Josh Triplett
2014-03-23 15:09 ` [patch 05/16] thermal: powerclamp: " Thomas Gleixner
2014-03-23 15:09 ` [patch 07/16] atm: firestream: Use del_timer_sync() in teardown path Thomas Gleixner
2014-03-26  1:06   ` David Miller
2014-03-23 15:09 ` [patch 08/16] atm: idt77105: Use del_timer_sync() in exit path Thomas Gleixner
2014-03-26  1:06   ` David Miller
2014-03-23 15:09 ` [patch 09/16] block: cpqarray: Use del_timer_sync() in teardown Thomas Gleixner
2014-03-23 15:09 ` [patch 10/16] block: umem: Use del_timer_sync() in exit path Thomas Gleixner
2014-03-23 15:09 ` [patch 11/16] block: xsysace; " Thomas Gleixner
2014-03-23 15:09 ` [patch 13/16] bt: hci-bcsp: Use del_timer_sync() in teardown path Thomas Gleixner
2014-03-23 17:30   ` Marcel Holtmann
2014-03-23 15:09 ` [patch 12/16] bt: bluecard: " Thomas Gleixner
2014-03-23 17:30   ` Marcel Holtmann
2014-03-23 15:09 ` [patch 14/16] bt: hci-h5: Use del_timer_sync() in exit path Thomas Gleixner
2014-03-23 17:30   ` Marcel Holtmann
2014-03-23 15:09 ` [patch 15/16] cpufreq: intel-pstate: Use del_timer_sync in intel_pstate_cpu_exit() Thomas Gleixner
2014-03-24  1:56   ` Rafael J. Wysocki
2014-03-24 14:18     ` Dirk Brandewie
2014-03-24  4:45   ` Viresh Kumar
2014-03-23 15:09 ` [patch 16/16] input: serio: hp_sdc: Use del_timer_sync() in exit path Thomas Gleixner
2014-03-24  0:24   ` Dmitry Torokhov
2014-03-23 22:34 ` [patch 00/16] timers: Plug debugobject leaks and use del_timer_sync() in exit/teardown Julia Lawall
2014-03-23 23:37   ` Thomas Gleixner
2014-03-24  6:50     ` Julia Lawall
2014-03-24  7:29     ` Julia Lawall
2014-03-24  9:03       ` Thomas Gleixner
2014-03-25 21:08   ` Thomas Gleixner
2014-03-25 21:19     ` Julia Lawall
2014-03-26 18:53     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140323150753.205530990@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=Julia.Lawall@lip6.fr \
    --cc=akpm@linux-foundation.org \
    --cc=josh@freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome