From: David Miller <davem@davemloft.net>
To: asuka.com@163.com
Cc: xeb@mail.ru, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv4: gre: Fix null pointer dereference in gre_cisco_err()
Date: Mon, 24 Mar 2014 15:14:17 -0400 (EDT) [thread overview]
Message-ID: <20140324.151417.474668383309974516.davem@davemloft.net> (raw)
In-Reply-To: <1395646471-637-1-git-send-email-asuka.com@163.com>
From: Wei Zhang <asuka.com@163.com>
Date: Mon, 24 Mar 2014 15:34:31 +0800
> When use the gre vport, openvswitch register a gre_cisco_protocol but
> does not supply a err_handler with it. The gre_cisco_err() call the
> err_handler without existence check, cause the kernel crash.
>
> This patch base on v3.14-rc7. But the bug affect all kernel newer than
> 3.11!
>
> Signed-off-by: Wei Zhang <asuka.com@163.com>
Rather, openvswitch should provide an appropriate ->err_handler() that
returns PACKET_RCVD or PACKET_REJECT.
I'm not applying this patch.
next prev parent reply other threads:[~2014-03-24 19:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 7:34 Wei Zhang
2014-03-24 7:49 ` wei zhang
2014-03-24 19:14 ` David Miller [this message]
2014-03-25 8:56 ` [PATCH] " wei zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140324.151417.474668383309974516.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=asuka.com@163.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xeb@mail.ru \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®