From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
linux-input@vger.kernel.org,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>
Subject: Re: [PATCH v2 12/15] ARM: at91: remove atmel_tsadcc platform_data
Date: Mon, 24 Mar 2014 10:46:51 +0100 [thread overview]
Message-ID: <20140324094650.GB20484@piout.net> (raw)
In-Reply-To: <532D8474.8020601@kernel.org>
On 22/03/2014 at 12:39:16 +0000, Jonathan Cameron wrote :
> On 17/03/14 13:57, Alexandre Belloni wrote:
> >Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> See below.
> >---
> > arch/arm/mach-at91/board.h | 3 ---
> > include/linux/platform_data/atmel.h | 7 -------
> > 2 files changed, 10 deletions(-)
> >
> >diff --git a/arch/arm/mach-at91/board.h b/arch/arm/mach-at91/board.h
> >index 6c08b341167d..4e773b55bc2d 100644
> >--- a/arch/arm/mach-at91/board.h
> >+++ b/arch/arm/mach-at91/board.h
> >@@ -118,9 +118,6 @@ struct isi_platform_data;
> > extern void __init at91_add_device_isi(struct isi_platform_data *data,
> > bool use_pck_as_mck);
> >
> >- /* Touchscreen Controller */
> >-extern void __init at91_add_device_tsadcc(struct at91_tsadcc_data *data);
> >-
> > /* CAN */
> > extern void __init at91_add_device_can(struct at91_can_data *data);
> >
> >diff --git a/include/linux/platform_data/atmel.h b/include/linux/platform_data/atmel.h
> >index cea9f70133c5..4b452c6a2f7b 100644
> >--- a/include/linux/platform_data/atmel.h
> >+++ b/include/linux/platform_data/atmel.h
> >@@ -86,13 +86,6 @@ struct atmel_uart_data {
> > struct serial_rs485 rs485; /* rs485 settings */
> > };
> >
> >- /* Touchscreen Controller */
> >-struct at91_tsadcc_data {
> >- unsigned int adc_clock;
> >- u8 pendet_debounce;
> >- u8 ts_sample_hold_time;
> >-};
> >-
> I believe this is still in use in the driver you don't remove until patch 14.
>
> Probably best to reorder the patches...
Indeed, you are right.
Nicolas, do you take care of that or should I send a v3 ?
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-24 9:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 13:56 [PATCH v2 00/15] iio: adc: at91 cleanups and atmel_tsadcc removal Alexandre Belloni
2014-03-17 13:56 ` [PATCH v2 01/15] ARM: at91: sam9g45: remove unused platform_data Alexandre Belloni
2014-03-17 13:56 ` [PATCH v2 02/15] ARM: at91: sam9260: " Alexandre Belloni
2014-03-17 13:56 ` [PATCH v2 03/15] iio: adc: at91: cleanup platform_data Alexandre Belloni
2014-03-17 13:56 ` [PATCH v2 04/15] iio: adc: at91_adc: Add support for touchscreens without TSMR Alexandre Belloni
2014-03-22 12:33 ` Jonathan Cameron
2014-03-17 13:56 ` [PATCH v2 05/15] ARM: at91: sam9m10g45ek: Add touchscreen support through at91_adc Alexandre Belloni
2014-03-22 12:34 ` Jonathan Cameron
2014-03-17 13:56 ` [PATCH v2 06/15] iio: adc: at91: remove unused include from include/mach Alexandre Belloni
2014-03-22 12:34 ` Jonathan Cameron
2014-03-17 13:57 ` [PATCH v2 07/15] iio: adc: at91: add sam9rl support Alexandre Belloni
2014-03-22 12:34 ` Jonathan Cameron
2014-03-17 13:57 ` [PATCH v2 08/15] ARM: at91: sam9rl: add at91_adc to support adc and touchscreen Alexandre Belloni
2014-03-22 12:35 ` Jonathan Cameron
2014-03-17 13:57 ` [PATCH v2 09/15] ARM: at91: sam9rlek add touchscreen support through at91_adc Alexandre Belloni
2014-03-17 13:57 ` [PATCH v2 10/15] ARM: at91: sam9g45: switch from atmel_tsadcc to at91_adc Alexandre Belloni
2014-03-17 13:57 ` [PATCH v2 11/15] ARM: at91: sam9rl: " Alexandre Belloni
2014-03-17 13:57 ` [PATCH v2 12/15] ARM: at91: remove atmel_tsadcc platform_data Alexandre Belloni
2014-03-22 12:39 ` Jonathan Cameron
2014-03-24 9:46 ` Alexandre Belloni [this message]
2014-03-17 13:57 ` [PATCH v2 13/15] ARM: at91: remove atmel_tsadcc from sama5_defconfig Alexandre Belloni
2014-03-17 13:57 ` [PATCH v2 14/15] Input: atmel_tsadcc: remove driver Alexandre Belloni
2014-03-17 13:57 ` [PATCH v2 15/15] ARM: at91/dt: at91-cosino_mega2560 remove useless tsadcc node Alexandre Belloni
2014-03-17 14:00 ` Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140324094650.GB20484@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome