mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dborkman@redhat.com
Cc: ast@plumgrid.com, netdev@vger.kernel.org, hagen@jauu.net,
	keescook@chromium.org, pmoore@redhat.com, mingo@kernel.org,
	hpa@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 8/9] net: filter: rework/optimize internal BPF interpreter's instruction set
Date: Tue, 25 Mar 2014 20:17:12 -0400 (EDT)	[thread overview]
Message-ID: <20140325.201712.1651156258234145348.davem@davemloft.net> (raw)
In-Reply-To: <1395749457-16178-9-git-send-email-dborkman@redhat.com>

From: Daniel Borkmann <dborkman@redhat.com>
Date: Tue, 25 Mar 2014 13:10:56 +0100

>   - Conditional jt/jf targets replaced with jt/fall-through,
>     and forward/backward jumps now possible as well

Ummm... does anyone even remember why backwards jumps were not allowed
in the original BPF?

It's to guarentee forward progress in the filter.

Allowing branching backward would allow endless loops.

Please remove this feature.

  reply	other threads:[~2014-03-26  0:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1395749457-16178-1-git-send-email-dborkman@redhat.com>
2014-03-25 12:10 ` Daniel Borkmann
2014-03-26  0:17   ` David Miller [this message]
2014-03-26  0:24     ` H. Peter Anvin
2014-03-26  0:46       ` David Miller
2014-03-26  1:58         ` Alexei Starovoitov
2014-03-26 16:22           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140325.201712.1651156258234145348.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ast@plumgrid.com \
    --cc=dborkman@redhat.com \
    --cc=hagen@jauu.net \
    --cc=hpa@linux.intel.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pmoore@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®