From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754715AbaCZBTM (ORCPT ); Tue, 25 Mar 2014 21:19:12 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:33444 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573AbaCZBTL (ORCPT ); Tue, 25 Mar 2014 21:19:11 -0400 Date: Tue, 25 Mar 2014 21:19:09 -0400 (EDT) Message-Id: <20140325.211909.1213660358814903074.davem@davemloft.net> To: monamagarwal123@gmail.com Cc: fubar@us.ibm.com, vfalico@redhat.com, andy@greyhouse.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/net: Use RCU_INIT_POINTER(x, NULL) in bonding/bond_options.c From: David Miller In-Reply-To: <1395599417-7041-1-git-send-email-monamagarwal123@gmail.com> References: <1395599417-7041-1-git-send-email-monamagarwal123@gmail.com> X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Tue, 25 Mar 2014 18:19:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Monam Agarwal Date: Mon, 24 Mar 2014 00:00:17 +0530 > This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) > > The rcu_assign_pointer() ensures that the initialization of a structure > is carried out before storing a pointer to that structure. > And in the case of the NULL pointer, there is no structure to initialize. > So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL) > > Signed-off-by: Monam Agarwal Applied.