mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: SeongJae Park <sj38.park@gmail.com>
Cc: chad@dahc.us, viro@zeniv.linux.org.uk,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: silicom: hide conditionally used function in condition
Date: Wed, 26 Mar 2014 05:27:48 -0700	[thread overview]
Message-ID: <20140326122748.GB28816@kroah.com> (raw)
In-Reply-To: <1395813530-2684-1-git-send-email-sj38.park@gmail.com>

On Wed, Mar 26, 2014 at 02:58:50PM +0900, SeongJae Park wrote:
> bp_proc_create() be called only when BP_PROC_SUPPORT defined but its
> definition live outside of #ifdef BP_PROC_SUPPORT and cause following
> trivial build warning:
> drivers/staging/silicom/bpctl_mod.c:6786:12: warning:
> ‘bp_proc_create’ defined but not used [-Wunused-function]
>  static int bp_proc_create(void)
>             ^
> 
> Fix the warning by hide the definition inside #ifdef BP_PROC_SUPPORT.

But no one can define that value, so why add more usages, it should just
be ripped out.  Just remove everything "hidden" by this option as no
one is obviously using it, and no driver should be messing around in
/proc anyway.

thanks,

greg k-h

  reply	other threads:[~2014-03-26 12:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-26  5:58 SeongJae Park
2014-03-26 12:27 ` Greg KH [this message]
2014-03-26 12:34   ` SeongJae Park
2014-03-26 14:24 ` [PATCH v2] staging: silicom: remove BP_PROC_SUPPORT dependant code SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140326122748.GB28816@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chad@dahc.us \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sj38.park@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®