mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, tytso@mit.edu, dborkman@redhat.com
Subject: Re: [PATCH v2] random32: avoid attempt to late reseed if in the middle of seeding
Date: Thu, 27 Mar 2014 07:17:42 +0100	[thread overview]
Message-ID: <20140327061742.GM22086@order.stressinduktion.org> (raw)
In-Reply-To: <1395900095-15254-2-git-send-email-sasha.levin@oracle.com>

On Thu, Mar 27, 2014 at 02:01:35AM -0400, Sasha Levin wrote:
> Commit 4af712e8df ("random32: add prandom_reseed_late() and call when
> nonblocking pool becomes initialized") has added a late reseed stage
> that happens as soon as the nonblocking pool is marked as initialized.
> 
> This fails in the case that the nonblocking pool gets initialized
> during __prandom_reseed()'s call to get_random_bytes(). In that case
> we'd double back into __prandom_reseed() in an attempt to do a late
> reseed - deadlocking on 'lock' early on in the boot process.
> 
> Instead, just avoid even waiting to do a reseed if a reseed is already
> occuring.
> 
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

Thanks for fixing this!

Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>


  reply	other threads:[~2014-03-27  6:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27  6:01 [PATCH] random32: assign to network folks in MAINTAINERS Sasha Levin
2014-03-27  6:01 ` [PATCH v2] random32: avoid attempt to late reseed if in the middle of seeding Sasha Levin
2014-03-27  6:17   ` Hannes Frederic Sowa [this message]
2014-03-27  8:52   ` Daniel Borkmann
2014-03-28 20:03 ` [PATCH] random32: assign to network folks in MAINTAINERS David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140327061742.GM22086@order.stressinduktion.org \
    --to=hannes@stressinduktion.org \
    --cc=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sasha.levin@oracle.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®