mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jake Edge <jake@edge2.net>
To: Joe Perches <joe@perches.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jade Bilkey <herself@thefumon.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: fix bcm/hostmibs.c checkpatch problems
Date: Fri, 28 Mar 2014 12:49:01 -0600	[thread overview]
Message-ID: <20140328124901.6371fa1a@quetzal.lan> (raw)
In-Reply-To: <1395596709.13968.30.camel@joe-AO722>

On Sun, 23 Mar 2014 10:45:09 -0700 Joe Perches wrote:
> On Sat, 2014-03-22 at 09:50 -0600, Jake Edge wrote:
> > Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c
> 
> Making code checkpatch clean shouldn't be the primary goal here.

Perhaps not, but it was *my* goal :)

> Removing uses of Hungarian-style notation, CamelCase naming, and
> long variable names would be more helpful overall.

I don't have enough experience to feel comfortable about doing that
yet, but I did take some of your suggestions and am respinning the
patch ...

thanks,

jake 

-- 
Jake Edge - jake@edge2.net - http://www.edge2.net

      reply	other threads:[~2014-03-28 18:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-22 15:50 Jake Edge
2014-03-23 17:45 ` Joe Perches
2014-03-28 18:49   ` Jake Edge [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140328124901.6371fa1a@quetzal.lan \
    --to=jake@edge2.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=herself@thefumon.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®