From: Stephen Rothwell <sfr@canb.auug.org.au>
To: David Decotigny <decot@googlers.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jamal Hadi Salim <jhs@mojatatu.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Eric Dumazet <edumazet@google.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Weilong Chen <chenweilong@huawei.com>,
Jiri Pirko <jiri@resnulli.us>, Amir Vadai <amirv@mellanox.com>,
Michael Dalton <mwdalton@google.com>,
Al Viro <viro@ZenIV.linux.org.uk>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v1] net-sysfs: expose number of link up/down transitions
Date: Fri, 28 Mar 2014 16:17:25 +1100 [thread overview]
Message-ID: <20140328161725.e044dd9417cae3020068f350@canb.auug.org.au> (raw)
In-Reply-To: <cc4b88e880d31d8d71a5c8872a64c9d665cd097e.1395980768.git.decot@googlers.com>
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
Hi David,
On Thu, 27 Mar 2014 21:35:00 -0700 David Decotigny <decot@googlers.com> wrote:
>
> Tested:
> grep . /sys/class/net/*/count_link_*
> + ip link set dev X down/up
>
> Signed-off-by: David Decotigny <decot@googlers.com>
It is not a very enlightening commit message. You should tell us why we
should add this to the kernel.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-28 5:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1395980768.git.decot@googlers.com>
2014-03-28 4:35 ` David Decotigny
2014-03-28 5:17 ` Stephen Rothwell [this message]
2014-03-28 5:56 ` Florian Fainelli
2014-03-28 6:25 ` Jiri Pirko
2014-03-28 16:51 ` Florian Fainelli
2014-03-28 17:46 ` Eric Dumazet
2014-03-28 17:59 ` Florian Fainelli
2014-03-28 18:08 ` Eric Dumazet
2014-03-28 18:19 ` David Decotigny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328161725.e044dd9417cae3020068f350@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=amirv@mellanox.com \
--cc=chenweilong@huawei.com \
--cc=davem@davemloft.net \
--cc=decot@googlers.com \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=mwdalton@google.com \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®