From: Felipe Balbi <balbi@ti.com>
To: Julius Werner <jwerner@chromium.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Vincent Palatin <vpalatin@chromium.org>,
Andrew Bresticker <abrestic@chromium.org>,
Jim Lin <jilin@nvidia.com>
Subject: Re: [PATCH] usb: xhci: Correct last context entry calculation for Configure Endpoint
Date: Fri, 28 Mar 2014 11:42:35 -0500 [thread overview]
Message-ID: <20140328164235.GM17820@saruman.home> (raw)
In-Reply-To: <1395772963-14127-1-git-send-email-jwerner@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
Hi,
On Tue, Mar 25, 2014 at 11:42:43AM -0700, Julius Werner wrote:
> @@ -2723,8 +2697,19 @@ int xhci_check_bandwidth(struct usb_hcd *hcd, struct usb_device *udev)
> ctrl_ctx->drop_flags == 0)
> return 0;
>
> - xhci_dbg(xhci, "New Input Control Context:\n");
> + /* Fix up Context Entries field. Minimum value is EP0 == BIT(1). */
> slot_ctx = xhci_get_slot_ctx(xhci, virt_dev->in_ctx);
> + for (i = 31; i >= 1; i--) {
> + u32 le32 = cpu_to_le32(BIT(i));
can you use __le32 instead of u32 here, just to make sure we can make
good use of sparse ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-03-28 16:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 18:42 Julius Werner
2014-03-28 16:42 ` Felipe Balbi [this message]
2014-03-28 16:49 ` Mathias Nyman
2014-03-31 21:25 ` Sarah Sharp
2014-04-01 21:29 ` Julius Werner
2014-04-01 22:01 ` Alan Stern
2014-04-29 3:11 ` Julius Werner
2014-04-29 17:16 ` Mathias Nyman
2014-04-29 17:17 ` Julius Werner
2014-04-29 17:38 ` [PATCH v2] " Julius Werner
2014-04-30 23:04 ` Sarah Sharp
2014-04-30 23:28 ` Felipe Balbi
2014-04-30 23:31 ` Sarah Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328164235.GM17820@saruman.home \
--to=balbi@ti.com \
--cc=abrestic@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jilin@nvidia.com \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=sarah.a.sharp@linux.intel.com \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®