From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: artagnon@gmail.com, Linux Kernel <linux-kernel@vger.kernel.org>,
hskinnemoen@gmail.com
Subject: Re: [PATCH] avr32: replace simple_strtoul() with kstrtoul()
Date: Mon, 31 Mar 2014 08:56:37 +0200 [thread overview]
Message-ID: <20140331065637.GA21509@samfundet.no> (raw)
In-Reply-To: <CACVxJT_vYPeQqvDHT-TELb+EzcaE+YzTLnSUkBLVf_vm_zGCng@mail.gmail.com>
Around Wed 19 Mar 2014 12:52:35 +0300 or thereabout, Alexey Dobriyan wrote:
>> - val = simple_strtoul(buf, &endp, 0);
>> - if (endp == buf || val > 0x3f)
>> - return -EINVAL;
>> + ret = kstrtoul(buf, 0, &val);
>> + if (ret)
>> + return ret;
>> val = (val << 12) | (sysreg_read(PCCR) & 0xfffc0fff);
>
> you removed 0x3f check
>
> this conversion is not trivial as it seems
Is anybody going to update this patch? I planned to push early this round, as
others are waiting for AVR32 changes.
--
Best regards,
Hans-Christian Egtvedt
next prev parent reply other threads:[~2014-03-31 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 9:52 Alexey Dobriyan
2014-03-31 6:56 ` Hans-Christian Egtvedt [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-18 21:25 Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331065637.GA21509@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=adobriyan@gmail.com \
--cc=artagnon@gmail.com \
--cc=hskinnemoen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome