From: Mark Rutland <mark.rutland@arm.com>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"rob@landley.net" <rob@landley.net>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6] mfd: arizona: Update DT binding to support LDO1 init_data
Date: Mon, 31 Mar 2014 16:30:41 +0100 [thread overview]
Message-ID: <20140331153041.GB15064@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1396267187-30580-5-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Mon, Mar 31, 2014 at 12:59:45PM +0100, Charles Keepax wrote:
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index 0e295c9..c019e73 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -40,6 +40,13 @@ Optional properties:
> the chip default will be used. If present exactly five values must
> be specified.
>
> + - ldo1 : Initial data for the LDO1 regulator, as covered in
> + Documentation/devicetree/bindings/regulator/regulator.txt
This seems to be a node rather than a property, judging from the code.
Please describe properties separately from sub-nodes and their
properties. That also covers the micvdd addition in patch 6.
Thanks,
Mark.
> +
> + - DCVDD-supply : Power supply, only needs to be specified if DCVDD is being
> + externally supplied. As covered in
> + Documentation/devicetree/bindings/regulator/regulator.txt
> +
> Example:
>
> codec: wm5102@1a {
> --
> 1.7.2.5
>
>
next prev parent reply other threads:[~2014-03-31 15:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 11:59 [PATCH 0/6] Arizona Regulator Updates v4 Charles Keepax
2014-03-31 11:59 ` [PATCH 1/6] mfd: arizona: Factor out read of device tree GPIOs Charles Keepax
2014-03-31 11:59 ` [PATCH 2/6] regulator: arizona-ldo1: Move setup processing from arizona-core Charles Keepax
2014-03-31 11:59 ` [PATCH 3/6] regulator: arizona-ldo1: Add processing of init_data from device tree Charles Keepax
2014-03-31 11:59 ` [PATCH 4/6] mfd: arizona: Update DT binding to support LDO1 init_data Charles Keepax
2014-03-31 15:30 ` Mark Rutland [this message]
2014-03-31 11:59 ` [PATCH 5/6] regulator: arizona-micsupp: Add processing of init_data from device tree Charles Keepax
2014-03-31 11:59 ` [PATCH 6/6] mfd: arizona: Update DT binding to support MICVDD init_data Charles Keepax
2014-04-01 8:27 [PATCH 0/6] Arizona Regulator Updates v5 Charles Keepax
2014-04-01 8:27 ` [PATCH 4/6] mfd: arizona: Update DT binding to support LDO1 init_data Charles Keepax
2014-04-16 9:01 [PATCH 0/6] Arizona Regulator Updates v6 Charles Keepax
2014-04-16 9:01 ` [PATCH 4/6] mfd: arizona: Update DT binding to support LDO1 init_data Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331153041.GB15064@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®