From: Cyrill Gorcunov <gorcunov@openvz.org>
To: linux-kernel@vger.kernel.org
Cc: shawn@churchofgit.com, tglx@linutronix.de,
akpm@linux-foundation.org, avagin@openvz.org,
xemul@parallels.com, gorcunov@openvz.org
Subject: [rfc 1/2] timerfd: Implement show_fdinfo method
Date: Mon, 31 Mar 2014 21:54:08 +0400 [thread overview]
Message-ID: <20140331175957.509391054@openvz.org> (raw)
In-Reply-To: <20140331175407.400476950@openvz.org>
[-- Attachment #1: timerfd-show-fdinfo --]
[-- Type: text/plain, Size: 1380 bytes --]
For checkpoint/restore of timerfd files we need to know the clock
type being used on timerfd creation. Thus implement show_fdinfo
method where we print out the type.
Also to minimize the number of calls print out the ticks as well
(thus one read of fdinfo entry would eliminate the need of doing
read() over timerfd itself).
CC: Shawn Landden <shawn@churchofgit.com>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Andrey Vagin <avagin@openvz.org>
CC: Pavel Emelyanov <xemul@parallels.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
fs/timerfd.c | 9 +++++++++
1 file changed, 9 insertions(+)
Index: linux-2.6.git/fs/timerfd.c
===================================================================
--- linux-2.6.git.orig/fs/timerfd.c
+++ linux-2.6.git/fs/timerfd.c
@@ -284,11 +284,20 @@ static ssize_t timerfd_read(struct file
return res;
}
+static int timerfd_show(struct seq_file *m, struct file *file)
+{
+ struct timerfd_ctx *ctx = file->private_data;
+
+ return seq_printf(m, "clockid: %d ticks: %llu\n",
+ ctx->clockid, (unsigned long long)ctx->ticks);
+}
+
static const struct file_operations timerfd_fops = {
.release = timerfd_release,
.poll = timerfd_poll,
.read = timerfd_read,
.llseek = noop_llseek,
+ .show_fdinfo = timerfd_show,
};
static int timerfd_fget(int fd, struct fd *p)
next prev parent reply other threads:[~2014-03-31 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 17:54 [rfc 0/2] timerfd -- implement missing parts to checkpoint and restore timerfd state Cyrill Gorcunov
2014-03-31 17:54 ` Cyrill Gorcunov [this message]
2014-03-31 19:43 ` [rfc 1/2] timerfd: Implement show_fdinfo method Thomas Gleixner
2014-03-31 19:51 ` Cyrill Gorcunov
2014-03-31 17:54 ` [rfc 2/2] docs: procfs -- Document timerfd output Cyrill Gorcunov
2014-03-31 18:31 ` Andrey Wagin
2014-03-31 18:43 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331175957.509391054@openvz.org \
--to=gorcunov@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn@churchofgit.com \
--cc=tglx@linutronix.de \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome