mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: linux@roeck-us.net, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: mmio: Fix the bug of 'offset' value parsing.
Date: Tue, 1 Apr 2014 13:38:22 +0100	[thread overview]
Message-ID: <20140401123822.GW2269@sirena.org.uk> (raw)
In-Reply-To: <1396247611-22289-1-git-send-email-Li.Xiubo@freescale.com>

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

On Mon, Mar 31, 2014 at 02:33:31PM +0800, Xiubo Li wrote:
> 'offset = *(u32 *)reg;', this will be okey for 32/64-bit register, but
> for 8/16-bit register, the 'offset' value will overflow.

This doesn't apply against regmap-v3.15, please check and resend.

> The core trace:
> ===============
> Unable to handle kernel paging request at virtual address ffbd0000
> pgd = 871e8000
> [ffbd0000] *pgd=00000000
> Internal error: Oops: 805 [#1] ARM
> Modules linked in:
> CPU: 0 PID: 1004 Comm: sh Not tainted 3.14.0-rc6+ #990
> task: 871baa40 ti: 87090000 task.ti: 87090000

Don't paste entire backtraces into commit messages, they're enormous and
most of the detail isn't useful making it easy to miss relevant
information - either pick relevant sections or just describe the
failure.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-04-01 12:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31  6:33 Xiubo Li
2014-04-01 12:38 ` Mark Brown [this message]
2014-04-02  3:13   ` Li.Xiubo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140401123822.GW2269@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Li.Xiubo@freescale.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®