mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Loc Ho <lho@apm.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH libata/for-3.15-fixes] libata: drop COMPILE_TEST from AHCI_XGENE
Date: Wed, 2 Apr 2014 11:58:59 -0400	[thread overview]
Message-ID: <20140402155859.GB16631@htj.dyndns.org> (raw)
In-Reply-To: <20140402155357.GA16631@htj.dyndns.org>

On Wed, Apr 02, 2014 at 11:53:57AM -0400, Tejun Heo wrote:
>  config AHCI_XGENE
>  	tristate "APM X-Gene 6.0Gbps AHCI SATA host controller support"
> -	depends on ARM64 || COMPILE_TEST
> +	depends on ARM64
>  	select PHY_XGENE

So, an alternative would be doing

	select PHY_XGENE if ARM64

butI don't think it'd be worthwhile to go above and beyond for
COMPILE_TEST and it might cause other linkage issues down the road.

Thanks.

-- 
tejun

  reply	other threads:[~2014-04-02 15:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01 18:49 [GIT PULL] USB patches for 3.15-rc1 Greg KH
2014-04-02  0:28 ` Linus Torvalds
2014-04-02  2:28   ` Greg KH
2014-04-02  5:42     ` Loc Ho
2014-04-02 13:06       ` Kishon Vijay Abraham I
2014-04-02 14:45         ` Bartlomiej Zolnierkiewicz
2014-04-02 15:49         ` Loc Ho
2014-04-02 15:53           ` [PATCH libata/for-3.15-fixes] libata: drop COMPILE_TEST from AHCI_XGENE Tejun Heo
2014-04-02 15:58             ` Tejun Heo [this message]
2014-04-02 16:22             ` Tejun Heo
2014-04-02 16:36               ` Tejun Heo
2014-04-03 14:32               ` Bartlomiej Zolnierkiewicz
2014-04-03 14:49                 ` Tejun Heo
2014-04-02 16:41             ` [PATCH libata/for-3.15-fixes] libata: make AHCI_XGENE depend on PHY_XGENE Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140402155859.GB16631@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=lho@apm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®