From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933518AbaDBXNV (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Apr 2014 19:13:21 -0400
Received: from violet.fr.zoreil.com ([92.243.8.30]:44337 "EHLO
	violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933423AbaDBXNT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Apr 2014 19:13:19 -0400
Date: Thu, 3 Apr 2014 01:12:35 +0200
From: Francois Romieu <romieu@fr.zoreil.com>
To: Struan Bartlett <struan.bartlett@gmail.com>
Cc: Matt Mackall <mpm@selenic.com>, linux-kernel@vger.kernel.org,
        Andreas Schwab <schwab@linux-m68k.org>, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Nikolay Aleksandrov <nikolay@redhat.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Pirko <jiri@resnulli.us>, Joe Perches <joe@perches.com>,
        Dan Aloni <alonid@postram.com>
Subject: Re: [PATCH v3] netconsole: Add tty driver
Message-ID: <20140402231235.GA5013@electric-eye.fr.zoreil.com>
References: <20140402185904.GD11734@NewsNow.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140402185904.GD11734@NewsNow.co.uk>
X-Organisation: Land of Sunshine Inc.
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Struan Bartlett <struan.bartlett@gmail.com> :
[...]
> --- a/drivers/net/netconsole.c	2014-03-31 04:40:15.000000000 +0100
> +++ b/drivers/net/netconsole.c	2014-04-01 11:58:50.000000000 +0100
> @@ -15,6 +15,7 @@
>   *               generic card hooks
>   *               works non-modular
>   * 2003-09-07    rewritten with netpoll api
> + * 2014-03-31    tty driver by Struan Bartlett

Useless.

[...]
> +static int netconsole_tty_put_char(struct tty_struct *tty, unsigned char ch)
> +{
> +	char temp[2] = { ch, 0 };
> +	_write_msg(temp, 1);

Please add an empty line after declaration.

[...]
> @@ -802,11 +857,39 @@ static int __init init_netconsole(void)
>  	if (err)
>  		goto undonotifier;
>  
> +	netconsole_tty_driver = alloc_tty_driver(1);

alloc_tty_driver is said deprecated in include/linux/tty_driver.h

http://marc.info/?l=linux-netdev&m=139629339513575 may delay things a bit.
If so please be patient.

-- 
Ueimor