From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Mark Brown <broonie@kernel.org>,
Grant Likely <grant.likely@secretlab.ca>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] drivercore: deferral race condition fix
Date: Wed, 2 Apr 2014 16:18:57 -0700 [thread overview]
Message-ID: <20140402231857.GB26696@kroah.com> (raw)
In-Reply-To: <533BB04E.9000206@ti.com>
On Wed, Apr 02, 2014 at 09:38:06AM +0300, Peter Ujfalusi wrote:
> Hi Greg,
>
> On 03/04/2014 06:56 AM, Mark Brown wrote:
> > On Mon, Mar 03, 2014 at 10:26:59AM +0200, Peter Ujfalusi wrote:
> >
> >> I think it is correct to detect this situation without the need to have non
> >> related drivers to be probed.
> >> The patch is doing this exactly: detects if we had successful parallel driver
> >> probe(s) while another driver was probing which ends up requesting to be
> >> deferred. We only try the deferred list again if this condition has been
> >> detected, we do not loop on the deferred list, we do not try the list again if
> >> there were no other drivers loaded since nothing happened which could satisfy
> >> the driver asking to be deferred.
> >
> > It's certainly the simplest approach I can think of - anything else
> > would seem to involve looking to see if we're running deferred probes
> > and trying to add things to the list while that's going on which seems
> > like it might be hairy.
>
> Do you want me to resend this patch in hope that it is going to be taken or do
> you have other method in mind to deal with the situation I have described and
> fixed with this patch?
Can you resend, I've totally lost the idea of the original patch. And
if others agree with it, getting acks from them (like Grant) would be
great.
thanks,
greg k-h
next prev parent reply other threads:[~2014-04-02 23:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 7:06 Peter Ujfalusi
2014-03-01 0:33 ` Greg Kroah-Hartman
2014-03-03 8:26 ` Peter Ujfalusi
2014-03-04 4:56 ` Mark Brown
2014-04-02 6:38 ` Peter Ujfalusi
2014-04-02 23:18 ` Greg Kroah-Hartman [this message]
2014-04-03 9:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140402231857.GB26696@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®