From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jimmy Li <coder.liss@gmail.com>
Cc: "Joe Perches" <joe@perches.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Teodora Baluta" <teobaluta@gmail.com>,
"Peter P Waskiewicz Jr" <peter.p.waskiewicz.jr@intel.com>,
"Michael Gunselmann" <michael.gunselmann@studium.uni-erlangen.de>,
"Lisa Nguyen" <lisa@xenapiadmin.com>,
"Martin Hofmann" <martin.hofmann@studium.uni-erlangen.de>,
"Malcolm Priestley" <tvboxspy@gmail.com>,
=?utf-8?B?VMO8bGluIMSwemVy?= <tulinizer@gmail.com>,
"Archana kumari" <archanakumari959@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drivers/staging/vt6655/iwctl.c fix a sparse warning
Date: Thu, 3 Apr 2014 20:42:08 +0300 [thread overview]
Message-ID: <20140403174208.GM6991@mwanda> (raw)
In-Reply-To: <20140403163229.GA21383@gmail.com>
On Fri, Apr 04, 2014 at 12:32:29AM +0800, Jimmy Li wrote:
> Signed-off-by: Jimmy Li <coder.liss@gmail.com>
You dropped the commit message which said which sparse warnings were
fixed. It should say something about the other cleanups as well. Also
the subject prefix isn't right. Use:
[PATCH v3] Staging: vt6655: iwctl.c: fix a sparse warning
Or something. "drivers/" doesn't add any information.
regards,
dan carpenter
prev parent reply other threads:[~2014-04-03 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 16:32 Jimmy Li
2014-04-03 17:42 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403174208.GM6991@mwanda \
--to=dan.carpenter@oracle.com \
--cc=archanakumari959@gmail.com \
--cc=coder.liss@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa@xenapiadmin.com \
--cc=martin.hofmann@studium.uni-erlangen.de \
--cc=michael.gunselmann@studium.uni-erlangen.de \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=teobaluta@gmail.com \
--cc=tulinizer@gmail.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome