From: Dan Carpenter <dan.carpenter@oracle.com>
To: armand.bastien@laposte.net
Cc: willy@meta-x.org, gregkh@linuxfoundation.org,
monamagarwal123@gmail.com, jake.champlin.27@gmail.com,
arnd@arndb.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging : panel : fix checkpatch warnings (linux-next)
Date: Thu, 3 Apr 2014 20:52:52 +0300 [thread overview]
Message-ID: <20140403175252.GN6991@mwanda> (raw)
In-Reply-To: <20140403165859.GA10253@plop.dartybox.com>
On Thu, Apr 03, 2014 at 06:59:09PM +0200, armand.bastien@laposte.net wrote:
> This patch fixes "Missing a blank line after declarations" checkpatch warning in panel.c.
>
>
> Signed-off-by: "Bastien Armand <armand.bastien@laposte.net>"
Fix your email client to use the proper From header. The signed-off-by
format is wrong as well (extra quotes). The subject should be:
[PATCH] staging: panel: add blank lines after declarations
The original had extra space characters. Don't put "(linux-next)" in
the permanent log. Be as specific as you can in roughly 52 characters.
Otherwise it looks ok.
regards,
dan carpenter
prev parent reply other threads:[~2014-04-03 17:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 16:59 armand.bastien
2014-04-03 17:16 ` Willy Tarreau
2014-04-03 17:52 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403175252.GN6991@mwanda \
--to=dan.carpenter@oracle.com \
--cc=armand.bastien@laposte.net \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jake.champlin.27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=monamagarwal123@gmail.com \
--cc=willy@meta-x.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome