From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/3] regulator: core: Add of_node_get to of_regulator_match
Date: Thu, 3 Apr 2014 22:50:27 +0100 [thread overview]
Message-ID: <20140403215027.GD14763@sirena.org.uk> (raw)
In-Reply-To: <1396535537-1352-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Thu, Apr 03, 2014 at 03:32:15PM +0100, Charles Keepax wrote:
> Currently, of_regulator_match does not increment the reference count of
> the of_nodes it takes new references to. This could cause the node
> pointer held to be invalid, by the time it is passed to the regulator
> core. This patchs adds an of_node_get when we copy each of_node pointer
> into the match structure.
Applied all, thanks. You just made all users of of_regulator_match()
buggy - I'm assuming you're going to be fixing that! :P
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-03 21:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 14:32 Charles Keepax
2014-04-03 14:32 ` [PATCH 2/3] regulator: core: Add helper to put of_nodes from matches Charles Keepax
2014-04-03 14:32 ` [PATCH 3/3] regulator: core: Get and put regulator of_node Charles Keepax
2014-04-03 21:50 ` Mark Brown [this message]
2014-04-04 8:33 ` [PATCH 1/3] regulator: core: Add of_node_get to of_regulator_match Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403215027.GD14763@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®