From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752825AbaDDMXG (ORCPT ); Fri, 4 Apr 2014 08:23:06 -0400 Received: from mail-qa0-f45.google.com ([209.85.216.45]:39749 "EHLO mail-qa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752658AbaDDMXE (ORCPT ); Fri, 4 Apr 2014 08:23:04 -0400 Date: Fri, 4 Apr 2014 08:22:59 -0400 From: Tejun Heo To: Li Zefan Cc: Linus Torvalds , "Eric W. Biederman" , David Miller , Linux Kernel Mailing List , Linux Containers , cgroups@vger.kernel.org Subject: Re: [GIT PULL] cgroup changes for v3.15-rc1 Message-ID: <20140404122259.GB5461@mtj.dyndns.org> References: <20140403164911.GE24119@htj.dyndns.org> <20140403194335.GC2472@mtj.dyndns.org> <533E7801.8090604@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <533E7801.8090604@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 04, 2014 at 05:14:41PM +0800, Li Zefan wrote: > [PATCH] cgroup: fix top cgroup refcnt leak > > As mount() and kill_sb() is not a one-to-one match, If we mount the same > cgroupfs in serveral mount points, and then umount all of them, kill_sb() > will be called only once. > > Try: > # mount -t cgroup -o cpuacct xxx /cgroup > # mount -t cgroup -o cpuacct xxx /cgroup2 > # cat /proc/cgroups | grep cpuacct > cpuacct 2 1 1 > # umount /cgroup > # umount /cgroup2 > # cat /proc/cgroups | grep cpuacct > cpuacct 2 1 1 > > You'll see cgroupfs will never be freed. > > Signed-off-by: Li Zefan Applied to cgroup/for-3.15-fixes. Thanks. -- tejun