mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Camille Bordignon <camille.bordignon@gmail.com>
Cc: paul.gortmaker@windriver.com, rashika.kheria@gmail.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: sep: Fix coding style
Date: Sat, 5 Apr 2014 11:59:29 -0700	[thread overview]
Message-ID: <20140405185929.GA16278@kroah.com> (raw)
In-Reply-To: <CAPF_0gn1r1R0eatLDqKUqmMc=n9xYufxbg==zv3RS4wS8fbJpA@mail.gmail.com>

On Sat, Apr 05, 2014 at 08:24:04PM +0200, Camille Bordignon wrote:
> This fixes coding style warning "Missing a blank line after
> declarations" in files sep_dev.h and sep_crypto.c.
> 
> Signed-off-by: Camille Bordignon <camille.bordignon@gmail.com>
> ---
> diff --git a/drivers/staging/sep/sep_crypto.c b/drivers/staging/sep/sep_crypto.c
> index 965485f..415f8ec 100644
> --- a/drivers/staging/sep/sep_crypto.c
> +++ b/drivers/staging/sep/sep_crypto.c
> @@ -93,6 +93,7 @@ static void sep_do_callback(struct work_struct *work)
>  {
>      struct sep_work_struct *sep_work = container_of(work,
>          struct sep_work_struct, work);
> +
>      if (sep_work != NULL) {
>          (sep_work->callback)(sep_work->data);
>          kfree(sep_work);

Tabs got converted all to spaces here, making it impossible to apply
your patch :(

Can you try this again after fixing up your email client?

thanks,

greg k-h

      reply	other threads:[~2014-04-05 18:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-05 18:24 Camille Bordignon
2014-04-05 18:59 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140405185929.GA16278@kroah.com \
    --to=greg@kroah.com \
    --cc=camille.bordignon@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=rashika.kheria@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome