mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Camille Begue <camille.begue44@gmail.com>
Cc: devel@driverdev.osuosl.org, Ian Abbott <abbotti@mev.co.uk>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] staging: comedi: Fix checkpatch warning
Date: Sat, 5 Apr 2014 15:19:07 -0700	[thread overview]
Message-ID: <20140405221907.GA31257@kroah.com> (raw)
In-Reply-To: <20140405220927.GA29836@kroah.com>

On Sat, Apr 05, 2014 at 03:09:27PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Apr 04, 2014 at 10:55:18PM +0200, Camille Begue wrote:
> > Wrap lines > 80 columns.
> > This patch is part of eudyptula challenge
> > 
> > Signed-off-by: Camille Begue <camille.begue44@gmail.com>
> > ---
> >  drivers/staging/comedi/comedi_fops.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> > index ea6dc36..0f05e87 100644
> > --- a/drivers/staging/comedi/comedi_fops.c
> > +++ b/drivers/staging/comedi/comedi_fops.c
> > @@ -1435,13 +1435,16 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
> >  	s = &dev->subdevices[cmd->subdev];
> >  
> >  	if (s->type == COMEDI_SUBD_UNUSED) {
> > -		dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
> > +		dev_dbg(dev->class_dev,
> > +			"%d not valid subdevice\n",
> > +			cmd->subdev);
> 
> Why did you split this into 3 lines, it only needs to be 2 like this:
> 		dev_dbg(dev->class_dev, "%d not valid subdevice\n",
> 			cmd->subdev);

Nevermind, you fixed it up later...

      reply	other threads:[~2014-04-05 22:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04 20:55 Camille Begue
2014-04-05 22:09 ` Greg Kroah-Hartman
2014-04-05 22:19   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140405221907.GA31257@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbotti@mev.co.uk \
    --cc=camille.begue44@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome