mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Pavel Machek" <pavel@ucw.cz>,
	"David Herrmann" <dh.herrmann@gmail.com>,
	akpm@linux-foundation.org, jslaby@suse.cz,
	"Bryan Wu" <cooloney@gmail.com>,
	rpurdie@rpsys.net, linux-kernel@vger.kernel.org,
	"Evan Broder" <evan@ebroder.net>,
	"Arnaud Patard" <arnaud.patard@rtp-net.org>,
	"Peter Korsgaard" <jacmet@sunsite.dk>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Matt Sealey" <matt@genesi-usa.com>,
	"Rob Clark" <robdclark@gmail.com>,
	"Niels de Vos" <devos@fedoraproject.org>,
	linux-arm-kernel@lists.infradead.org,
	"Steev Klimaszewski" <steev@genesi-usa.com>,
	blogic@openwrt.org, "Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH] Route keyboard LEDs through the generic LEDs layer.
Date: Sun, 6 Apr 2014 19:10:15 -0700	[thread overview]
Message-ID: <20140407021015.GA8518@core.coreip.homeip.net> (raw)
In-Reply-To: <20140331122323.GC6044@type.bordeaux.inria.fr>

Hi Samuel,

On Mon, Mar 31, 2014 at 02:23:23PM +0200, Samuel Thibault wrote:
> This permits to reassign keyboard LEDs to something else than keyboard "leds"
> state, by adding keyboard led and modifier triggers connected to a series
> of VT input LEDs, themselves connected to VT input triggers, which
> per-input device LEDs use by default.  Userland can thus easily change the LED
> behavior of (a priori) all input devices, or of particular input devices.
> 

I still have the same concern that I believe I already mentioned a while
ago: how do we reconcile the LED control via triggers with LED control
done through event devices? Currently, as far as I can see, they will be
clashing with each other. I.e. if I remap my capslock led to be the new
shiftlock and then userspace writes EV_LED/LED_CAPSL it would light up
my new "shift lock", right?

Also I wonder if we really need to have the multiplexing (VT-level) leds
in addition to per-device ones.

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2014-04-07  2:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31 12:23 Samuel Thibault
2014-04-01  7:02 ` Pali Rohár
2014-04-07  2:10 ` Dmitry Torokhov [this message]
2014-04-07  7:54   ` Samuel Thibault
2014-04-08  8:39     ` Dmitry Torokhov
2014-04-08 23:33       ` Samuel Thibault
2014-04-11  6:12         ` Samuel Thibault
2014-04-13  1:25           ` Dmitry Torokhov
2014-04-16 23:38             ` Samuel Thibault
2014-04-12 10:09       ` Pavel Machek
2014-04-13  1:30         ` Dmitry Torokhov
2014-10-01 18:42 ` Andrew Morton
2014-10-01 21:29   ` Samuel Thibault
2014-10-12 14:52     ` Pali Rohár
2014-10-15 23:15       ` Samuel Thibault
2014-10-15 23:29         ` Pali Rohár
2014-12-09 17:12           ` Pali Rohár
2014-12-09 20:22             ` Peter Korsgaard
2014-12-10  1:03               ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140407021015.GA8518@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnaud.patard@rtp-net.org \
    --cc=blogic@openwrt.org \
    --cc=cooloney@gmail.com \
    --cc=devos@fedoraproject.org \
    --cc=dh.herrmann@gmail.com \
    --cc=evan@ebroder.net \
    --cc=jacmet@sunsite.dk \
    --cc=jslaby@suse.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@genesi-usa.com \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=robdclark@gmail.com \
    --cc=rpurdie@rpsys.net \
    --cc=s.hauer@pengutronix.de \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=steev@genesi-usa.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome