From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jeff Layton <jlayton@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel mailing list <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Bruce Fields <bfields@fieldses.org>,
Matthew Wilcox <matthew@wil.cx>
Subject: Re: [GIT PULL] please pull file locking changes for 3.15
Date: Mon, 7 Apr 2014 22:27:02 +1000 [thread overview]
Message-ID: <20140407222702.9773d7369c05918a6f16151f@canb.auug.org.au> (raw)
In-Reply-To: <20140407071130.672d7e8e@tlielax.poochiereds.net>
[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]
Hi Jeff,
On Mon, 7 Apr 2014 07:11:30 -0400 Jeff Layton <jlayton@redhat.com> wrote:
>
> On Mon, 7 Apr 2014 11:37:06 +1000
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > On Fri, 4 Apr 2014 20:56:24 -0400 Jeff Layton <jlayton@redhat.com> wrote:
> > >
> > > Thanks for the feedback and for pulling this in anyway. I'll make sure
> > > to do all of that on subsequent pull requests.
> >
> > Also, please don't rebase what you have in linux-next before sending it to
> > Linus (without good reason). Especially if you then leave the linux-next
> > included branch as it was - since that may cause conflicts in my tree
> > (and so I notice the rebase).
>
> I don't think I did that though, did I? Both the branches I had in this
> case were based on 3.13-rc1.
OK, so the base stayed the same, but you recommitted all the same patches
(I didn't check to see if the commit messages changed) which due to some
other change caused conflicts in linux-next today :-( Not really a
biggie, but generally, you really shouldn't rewrite your commits just
before sending them to Linus.
> Now that Linus has pulled in the changes, am I OK to rebase the
> branches (or do a pull)?
At this point, you should just reset your next included branch to be in
Linus' tree beyond where Linus merged your tree, then it will be
effectively empty (unless you then add some more patches on top - but at
this point those should only be fixes).
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-04-07 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 13:31 Jeff Layton
2014-04-04 21:28 ` Linus Torvalds
2014-04-05 0:56 ` Jeff Layton
2014-04-07 1:37 ` Stephen Rothwell
2014-04-07 11:11 ` Jeff Layton
2014-04-07 12:27 ` Stephen Rothwell [this message]
2014-04-07 13:35 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407222702.9773d7369c05918a6f16151f@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®