From: Dave Martin <Dave.Martin@arm.com>
To: Jay Foad <jay.foad@gmail.com>
Cc: linux@arm.linux.org.uk, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: VFP: Fix emulation of multiply accumulate instructions
Date: Tue, 8 Apr 2014 14:13:11 +0100 [thread overview]
Message-ID: <20140408131256.GA5637@e103592.cambridge.arm.com> (raw)
In-Reply-To: <1395852549-2745-1-git-send-email-jay.foad@gmail.com>
On Wed, Mar 26, 2014 at 04:49:09PM +0000, Jay Foad wrote:
> The emulation for single and double precision multiply accumulate
> instructions correctly normalised any denormal values in the operand
> registers, but failed to normalise the destination (accumulator)
> register.
>
> This fixes https://bugzilla.kernel.org/show_bug.cgi?id=70501
>
> Signed-off-by: Jay Foad <jay.foad@gmail.com>
Reviewed-by: Dave Martin <Dave.Martin@arm.com>
This appears to be clean and straightforward, so if nobody else has
commented on this by the time -rc1 comes out, I suggest you rebase it
and send it to the patch system. (See
http://www.arm.linux.org.uk/developer/patches/info.php for details
-- make sure you read it carefully.)
Has this issue been hitting real-world users of the kernel, or is
this fixing a latent bug?
Cheers
---Dave
> ---
> arch/arm/vfp/vfpdouble.c | 2 ++
> arch/arm/vfp/vfpsingle.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/arch/arm/vfp/vfpdouble.c b/arch/arm/vfp/vfpdouble.c
> index 6cac43bd1d86..423f56dd4028 100644
> --- a/arch/arm/vfp/vfpdouble.c
> +++ b/arch/arm/vfp/vfpdouble.c
> @@ -866,6 +866,8 @@ vfp_double_multiply_accumulate(int dd, int dn, int dm, u32 fpscr, u32 negate, ch
> vdp.sign = vfp_sign_negate(vdp.sign);
>
> vfp_double_unpack(&vdn, vfp_get_double(dd));
> + if (vdn.exponent == 0 && vdn.significand)
> + vfp_double_normalise_denormal(&vdn);
> if (negate & NEG_SUBTRACT)
> vdn.sign = vfp_sign_negate(vdn.sign);
>
> diff --git a/arch/arm/vfp/vfpsingle.c b/arch/arm/vfp/vfpsingle.c
> index b252631b406b..4f96c1617aae 100644
> --- a/arch/arm/vfp/vfpsingle.c
> +++ b/arch/arm/vfp/vfpsingle.c
> @@ -915,6 +915,8 @@ vfp_single_multiply_accumulate(int sd, int sn, s32 m, u32 fpscr, u32 negate, cha
> v = vfp_get_float(sd);
> pr_debug("VFP: s%u = %08x\n", sd, v);
> vfp_single_unpack(&vsn, v);
> + if (vsn.exponent == 0 && vsn.significand)
> + vfp_single_normalise_denormal(&vsn);
> if (negate & NEG_SUBTRACT)
> vsn.sign = vfp_sign_negate(vsn.sign);
>
> --
> 1.8.3.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2014-04-08 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 16:49 Jay Foad
2014-04-08 13:13 ` Dave Martin [this message]
2014-04-14 15:26 ` Jay Foad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408131256.GA5637@e103592.cambridge.arm.com \
--to=dave.martin@arm.com \
--cc=jay.foad@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome