From: Peter Zijlstra <peterz@infradead.org>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Fernando Luis Vazquez Cao <fernando_b1@lab.ntt.co.jp>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Arjan van de Ven <arjan@linux.intel.com>,
Oleg Nesterov <oleg@redhat.com>,
Preeti U Murthy <preeti@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/2] nohz: use seqlock to avoid race on idle time stats v2
Date: Wed, 9 Apr 2014 15:42:13 +0200 [thread overview]
Message-ID: <20140409134213.GB10526@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CAK1hOcPjTxUaUjKYngpgsxY0yN-xNnGH7CVxPqjB4jb8r=Z74w@mail.gmail.com>
On Wed, Apr 09, 2014 at 02:49:55PM +0200, Denys Vlasenko wrote:
> > I doubt that users are interested in such random accounting. They want
> > to know either:
> >
> > 1) how much time was spent waiting on IO by the whole system
>
> Hmm, I think I just said the same thing :)
>
> > 2) how much time was spent waiting on IO per task
I think we already have enough cruft to measure that. We have delayacct
measuring this and schedstat also seems to measure this.
> > 3) how much time was spent waiting on IO per CPU that initiated
> > IOs, or per CPU which ran task completing IOs. In order to have
> > an overview on where these mostly happened.
I'm not entirely sure this makes sense in general. It only makes sense
in the specific case where tasks are affine to a single CPU and that cpu
is not part of any balance domain.
I think this is a specific enough case (exclusive cpusets in general)
that we can ignore it. After all, we do not have per cpuset load numbers
at all, so why bother with this one.
At which point I think Denys makes a fair argument.
next prev parent reply other threads:[~2014-04-09 13:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 2:01 [PATCH 0/2 v2] nohz: fix idle accounting in NO_HZ kernels Hidetoshi Seto
2014-03-31 2:08 ` [PATCH 1/2] nohz: use seqlock to avoid race on idle time stats v2 Hidetoshi Seto
2014-04-02 19:35 ` Denys Vlasenko
2014-04-03 7:02 ` Hidetoshi Seto
2014-04-03 9:51 ` Denys Vlasenko
2014-04-04 2:47 ` Hidetoshi Seto
2014-04-04 16:03 ` Frederic Weisbecker
2014-04-04 17:02 ` Denys Vlasenko
2014-04-05 10:08 ` Frederic Weisbecker
2014-04-05 14:56 ` Denys Vlasenko
2014-04-07 18:17 ` Frederic Weisbecker
2014-04-09 12:49 ` Denys Vlasenko
2014-04-09 13:42 ` Peter Zijlstra [this message]
2014-03-31 2:09 ` [PATCH 2/2] nohz, procfs: introduce get_cpu_idle/iowait_time_coarse Hidetoshi Seto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409134213.GB10526@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=fernando_b1@lab.ntt.co.jp \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=preeti@linux.vnet.ibm.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®